chore(stepfunction-tasks/route53-targets/lambda-events-source): break dependencies on experimental modules #14227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e integration packages
|
|
NetaNir
changed the title
NetaNir
commented
Apr 18, 2021
Comment on lines
+54
to
+55
| "props-no-arn-refs:@aws-cdk/aws-stepfunctions-tasks.BatchSubmitJobProps.jobDefinitionArn", | ||
| "props-no-arn-refs:@aws-cdk/aws-stepfunctions-tasks.BatchSubmitJobProps.jobQueueArn" |
NetaNir
changed the title
iliapolo
changed the title
iliapolo
approved these changes
Apr 18, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
pushed a commit
that referenced
this pull request
Apr 20, 2021
Increase the scrutiny on how breaking changes are formatted. Motivation A previous PR - #14227 - incorrectly specified breaking changes that standard-release failed to record in the changelog.
mergify bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
Increase the scrutiny on how breaking changes are formatted. Motivation A previous PR - #14227 - incorrectly specified breaking changes that standard-release failed to record in the changelog. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
Increase the scrutiny on how breaking changes are formatted. Motivation A previous PR - aws#14227 - incorrectly specified breaking changes that standard-release failed to record in the changelog. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
… dependencies on experimental modules (aws#14227) *chore(stepfunction-tasks/route53-targets/lambda-events-source): break dependencies on between stable and experimental modules
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Increase the scrutiny on how breaking changes are formatted. Motivation A previous PR - aws#14227 - incorrectly specified breaking changes that standard-release failed to record in the changelog. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stepfunction-tasks,route53-targets,events-targetsandlambda-events-sourceare all stable modules, as such they are not allowed to depend on experimental modules. This PR breaks these dependencies by "untyping" APIs, meaning accepting strings instead of types. In the future, when the experimental modules will become stable, the untyped APIs will be deprecated in favor of typed APIs.This work is in preparation of v2, in which all stable modules will be released under a single package -
aws-cdk-lib.BREAKING CHANGE:
CallApiGatewayHttpApiEndpointAPI now requires theapiIdand it's containingStack.BatchSubmitJobnow acceptjobDefinitionArnandjobQueueArn.RunBatchJobnow acceptjobDefinitionArnandjobQueueArn.ApiGatewayv2Domainwas replaced withApiGatewayv2DomainPropertieswhich acceptsregionalDomainNameandregionalHostedZoneId.clusterwas removed fromManagedKafkaEventSourcePropsand replaced withclusterArnBatchJobintegration now requires the arn and the Resource for the jobQueue and the jobDefinition.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license